Improve LB interface testing #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing nodes out of bounds causes ESPResSo to freeze.
Backport testcase from the 4.3 branch.
Also thermalize the fluid and document the non-VTK write functions.
KaiSzuttor
previously requested changes
Dec 17, 2020
This change better reflects what is actually carried out by these functions. Affects LB and EK modules.
KaiSzuttor
reviewed
Dec 17, 2020
testsuite/python/h5md.py
Outdated
| @@ -30,7 +30,7 @@ | |||
| import espressomd.io.writer | |||
| try: | |||
| import h5py # h5py has to be imported *after* espressomd (MPI) | |||
| skipIfMissingPythonPackage = ut.case._id | |||
| skipIfMissingPythonPackage = utx._id | |||
There was a problem hiding this comment.
okay, i still don't get why this should be a private function
There was a problem hiding this comment.
I've renamed it to no_skip in 08a674f
testsuite/python/mdanalysis.py
Outdated
| try: | ||
| import MDAnalysis as mda | ||
| from espressomd import MDA_ESP | ||
| skipIfMissingPythonPackage = ut.case._id | ||
| skipIfMissingPythonPackage = utx._id |
There was a problem hiding this comment.
Suggested change
| skipIfMissingPythonPackage = utx._id | |
| skipIfMissingPythonPackage = lambda x: x |
There was a problem hiding this comment.
this would be even more readable, right?
There was a problem hiding this comment.
we want to hide implementation details of python decorators (that's why unittest created _id() in the first place)
also, that lambda expression would be transformed into a regular function by autopep8
jngrad
force-pushed
the
lb_interface_coverage
branch
from
7db0322 to
89586a0
Compare
christophlohrmann
approved these changes
Dec 18, 2020
reinaual
approved these changes
Dec 20, 2020
jngrad
dismissed
KaiSzuttor’s stale review
requested changes have been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
print_vtk_*functions towrite_vtk_*functions in LB and EK to better reflect what they actually dobb2now needs zero-based indices)