Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Utils::Mpi::gather_buffer() functions #4075

Merged
merged 7 commits into from
Jan 14, 2021
Merged

Fix Utils::Mpi::gather_buffer() functions #4075

merged 7 commits into from
Jan 14, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Dec 26, 2020

Fixes #4074

Description of changes:

  • fix a bug that caused buffers to overwrite each others in Utils::Mpi::gather_buffer() when argument root was not 0
  • fix two broken unit tests for Utils::Mpi functions

@jngrad jngrad added this to the Espresso 4.2 milestone Dec 26, 2020
@jngrad jngrad marked this pull request as draft December 26, 2020 17:36
@jngrad
core: Fix broken Utils::Mpi::gather_buffer()
bdcbf72 
The function must move the first n_elem of the buffer on rank root
to the correct place, otherwise the first n_elem of the buffer on
rank 0 will overwrite them, and a hole of size n_elem can be found
somewhere in the final buffer. This bug doesn't affect code where
root is 0.
@jngrad jngrad marked this pull request as ready for review December 26, 2020 19:10
@jngrad
tests: Re-enable test case for 4 MPI ranks
e0a4404 
Move the out-of-bounds access check to dedicated functions.
@jngrad jngrad added the automerge Merge with kodiak label Jan 14, 2021
@kodiakhq kodiakhq bot merged commit 46372ec into espressomd:python Jan 14, 2021
@jngrad jngrad deleted the fix-4074 branch January 18, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor left review comments

@RudolfWeeber RudolfWeeber RudolfWeeber approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core Testcase
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

gather_buffer() functions are broken
3 participants
@jngrad @RudolfWeeber @KaiSzuttor