Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observables: make ids of ID based observable readonly. #4206

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

KaiSzuttor
Copy link
Member

No description provided.

@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Apr 6, 2021
@kodiakhq kodiakhq bot merged commit 304ec8d into espressomd:python Apr 6, 2021
@RudolfWeeber
Copy link
Contributor

If we decide we want to prevent users from changing what an observables observe over time, I think it needs to be done everywhere by making all the parameters read-only and only settable at construction, just like with correlators.
This PR changes the behavior for PidObservables, but looking at the code in src/script_interface/observables/ProfileObservable.hpp, one can also change histogram dimensions after the fact.
E.g., one an write to max_z of a density profile.

@KaiSzuttor
Copy link
Member Author

yes, all of the observables should be immutable

@KaiSzuttor KaiSzuttor deleted the observables branch April 7, 2021 06:59
@jngrad jngrad added this to the Espresso 4.2 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ApiChange automerge Merge with kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants