Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observables: make observables immutable. #4211

Merged
merged 2 commits into from
Apr 8, 2021
Merged

observables: make observables immutable. #4211

merged 2 commits into from
Apr 8, 2021

Conversation

KaiSzuttor
Copy link
Member

Fixes #4208

Description of changes:

  • made observables immutable

ToDo:

  • fix issue in python tests of cylindrical observables

@KaiSzuttor KaiSzuttor marked this pull request as ready for review April 8, 2021 12:32
jngrad
jngrad previously approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad jngrad added this to the Espresso 4.2 milestone Apr 8, 2021
@jngrad jngrad added the automerge Merge with kodiak label Apr 8, 2021
@kodiakhq kodiakhq bot merged commit c759866 into espressomd:python Apr 8, 2021
@jngrad jngrad added the BugFix label Apr 9, 2021
@jngrad jngrad mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweik fweik fweik left review comments

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
ApiChange automerge Merge with kodiak BugFix ScriptInterface
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

make observables immutable
3 participants
@KaiSzuttor @fweik @jngrad