Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMM1D maintenance #4311

Merged
merged 6 commits into from
Jul 27, 2021
Merged

MMM1D maintenance #4311

merged 6 commits into from
Jul 27, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jul 23, 2021

Closes #2071

Description of changes:

  • compile and test the Chebychev series for MMM1D on CPU
  • cleanup exceptions and assertions
  • fix -Wconversion compiler warnings
    • most were due to mixing signed int with CUDA's blockDim and blockId (dim structs have unsigned int fields)

jngrad added 6 commits July 23, 2021 14:30
@jngrad
core: Enable and test the Chebychev series
a977630
@jngrad
core: Modernize MMM1D code
304617c
@jngrad
core: Modernize MMM1D GPU code
88a2afe
@jngrad
core: Remove unused argument in CUDA kernels
268f528
@jngrad
core: Fix -Wconversion warnings in MMM1D code
c38907a
@jngrad
core: Update exception mechanism
66e54ea 
There can only be one MMM actor in an ESPResSo system,
so coulomb.method checks can be converted to assertions.
system.box_l cannot be <= 0. Remove the iostream global.
@jngrad jngrad added this to the Espresso 4.2 milestone Jul 23, 2021
@jngrad jngrad requested a review from reinaual July 23, 2021 13:30
@jngrad jngrad added the automerge Merge with kodiak label Jul 27, 2021
@kodiakhq kodiakhq bot merged commit 2d9e8ca into espressomd:python Jul 27, 2021
@jngrad jngrad deleted the test-chebychev branch July 27, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak CodeQuality Core
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

Low test coverage: Candidates for downgrade or removal
2 participants
@jngrad @reinaual