Remove Observable_stat global variables #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce code complexity by centralizing the custom reduction code into the Observable_stat class. Remove hazardous `extern int` statements inside class methods (risk of linking errors if the symbol name changes, prefer including the relevant header file).
Generate these observables on-demand. Move the private function _Observable_stat_to_dict() from the .pyx file to the .pxd file. Add the missing handle_error() guards in the Cython interface.
reinaual
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #2628
Description of changes:
Observable_statclass self-containedObservable_statglobal variables