-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle property ranges, remove ParticleRanges from P3M #4737
Particle property ranges, remove ParticleRanges from P3M #4737
Conversation
658feb0
to
6bb53e0
Compare
I have successfully changed all ParticleRange signatures of methods inside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending suggested changes.
fb3c90b
to
b53fbc7
Compare
b53fbc7
to
d0d4964
Compare
20e9b2d
to
b220eeb
Compare
Partial fix for #4721, closes #4696
Description of changes:
ParticlePropertyRange
struct containing static methods to transform aParticleRange
to aboost::iterator_range
of properties of the particles, such asForceRange
orParticleRange
, which can then be used in range-based for-loops.The refactoring of the P3M part is not finished yet, but I think this PR could also be extended to remove the ParticleRanges from the remaining Coulomb interactions.