Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable electrode tutorial #4824

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Fix unstable electrode tutorial #4824

merged 3 commits into from
Nov 24, 2023

Conversation

schlaicha
Copy link
Contributor

@schlaicha schlaicha commented Nov 24, 2023 •
edited
Loading

Fixes #4798

Description of changes:

  • change steepest descent parameters to more reasonable values in electrode_part2
  • re-enable test of electrode_part2
  • Limit Grahame test to 1 point / shorten CI test duration

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jngrad jngrad added Documentation automerge Merge with kodiak labels Nov 24, 2023
@kodiakhq kodiakhq bot merged commit 2c14952 into espressomd:python Nov 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Electrodes tutorial is unstable
2 participants
@schlaicha @jngrad