Remove more global variables #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encapsulate bonded interactions, collision detection, particle list, cluster structure analysis. Remove the SystemFacade class and rewrite the checkpointing mechanism to avoid double deserialization.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
reinaual
reviewed
Jul 31, 2024
There was a problem hiding this comment.
I tried to check everything within my capabilities. Most of it seems fine, but partially the commits are enormous and I can't say I understood the need for every change.
@RudolfWeeber do you want to take a look too? Otherwise I guess we trust in @jngrad and the testsuite and merge it.
Remove superflous runtime checks on the vector size. Address narrowing conversion compiler diagnostics.
reinaual
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4821
Partial fix for #2628
Partial fix for #4613
Description of changes:
MpiioandClusterStructurenow take a system object as argument