Merge pull request #340 from essentialkaos/develop

Version 12.57.1

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Changelog
 
+### 12.57.1
+
+* `[progress]` Fixed bug with updating progress settings
+
 ### 12.57.0
 
 * `[log]` Added interface for compatible loggers

ek.go

@@ -20,7 +20,7 @@ import (
 // ////////////////////////////////////////////////////////////////////////////////// //
 
 // VERSION is current ek package version
-const VERSION = "12.57.0"
+const VERSION = "12.57.1"
 
 // ////////////////////////////////////////////////////////////////////////////////// //
 

progress/examples_test.go

@@ -26,7 +26,7 @@ func SimpleExample() {
 	pbs.RefreshRate = 50 * time.Millisecond
 	pbs.IsSize = false
 
-	// You can update all settings except RefreshRate before and after]
+	// You can update all settings except RefreshRate before and after
 	// calling Start method. RefreshRate must be set before calling
 	// Start method.
 	pb.UpdateSettings(pbs)

progress/progress.go

@@ -141,10 +141,15 @@ func (b *Bar) Start() {
 	b.started = true
 	b.finished = false
 	b.startTime = time.Now()
-	b.ticker = time.NewTicker(b.settings.RefreshRate)
 	b.finishChan = make(chan bool)
 	b.finishGroup = sync.WaitGroup{}
 
+	if b.settings.RefreshRate >= time.Millisecond {
+		b.ticker = time.NewTicker(b.settings.RefreshRate)
+	} else {
+		b.ticker = time.NewTicker(100 * time.Millisecond)
+	}
+
 	if b.total > 0 {
 		b.passThruCalc = NewPassThruCalc(b.total, 10.0)
 	}

progress/progress_test.go

@@ -87,6 +87,9 @@ func (s *ProgressSuite) TestBar(c *C) {
 	pb.Finish() // should be skipped (not started)
 	c.Assert(pb.IsFinished(), Equals, false)
 
+	pbs.RefreshRate = 0
+	pb.UpdateSettings(pbs)
+
 	pb.Start()
 	pb.renderElements(false)