Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LP-82: Install localgov_publications module for review #395

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nbrettell
Copy link
Contributor

Include a summary of what this merge request involves (*)

Installs the localgov_publications module https://github.com/localgovdrupal/localgov_publications

Call out any relevant implementation decisions

  • Are there any links to back up your chosen methodology?
  • Why have you taken the approach?
  • Any particular problem areas?

If necessary, please include any relevant screenshots (If not already available on the JIRA ticket)

This PR has been tested in the following browsers

  • Arc
  • Edge
  • Chrome
  • Safari
  • Firefox
  • IE 11 (Windows)
  • iOS Chrome
  • iOS Safari
  • Android Chrome
  • Android Firefox
  • Android default

Comment on lines 3 to 4
enabled: false
client: client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thats just what cex gave me. Thought I had checked all other config files but looks like I missed this one, will remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly a candidate for config_split, but then again...

Certainly not a time to fiddle with config split at the mo.

Copy link
Contributor Author

@nbrettell nbrettell Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed (reverted changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants