Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[👌 IMPROVE] test script #68

Closed
wants to merge 4 commits into from
Closed

[👌 IMPROVE] test script #68

wants to merge 4 commits into from

Conversation

andrei-pavel
Copy link
Contributor

  • kind syntax has changed, make it work with kind version 0.7.0
  • rather than cleaning up at the end, use traps to cleanup in case script fails mid-way
  • rather than timing out the killer for five seconds and hope it has written the annotations by then, wait for the killer to finish by looking into what it writes to standard output and then send a kill signal to finish the killer which the timeout already did before anyway, there's no compromise there, the script now ends instantaneously from the second run onwards since on the first run it creates the kind cluster

@andrei-pavel
Copy link
Contributor Author

Specifically, this is the kind command that didn't work anymore:

kind get kubeconfig-path --name='kind'

And it's deprecation is documented somewhere around here: kubernetes-sigs/cluster-api#1796

@andrei-pavel
Copy link
Contributor Author

one month celebration, although pull requests don't age well like fine wine, is there anything I can do to speed things up?

@JorritSalverda JorritSalverda changed the base branch from master to main September 23, 2020 15:32
@andrei-pavel andrei-pavel closed this by deleting the head repository Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants