Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added slither github action to v8 and minor changes #46

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

niccolopetti
Copy link

As referenced in #27 adding static security analysis in the CI pipeline is something desired before releasing v8,
this PR adds that, and a few changes suggested by slither.

I think with this addition, all tests passing and no issues found by slither v8 might be ready to be released (always stating code is unaudited)

@estarriolvetch
Copy link
Owner

Wow this is awesome!! Thank you :)

I try to find the full slither analysis report, but I cannot find it. Can you point to me where it is?

@niccolopetti
Copy link
Author

You're welcome!
On my fork they appear on the Security tab like this, you might need to fork my repo and push something as a test to trigger the action (there has to be a better way but that's the quickest solution that came to my mind rn)
image
to make slither reports publicly visible something like https://github.com/crytic/slither-action#example-workflow-markdown-report might be implemented, that should create issues in the repo, but it might become a bit messy

@estarriolvetch estarriolvetch removed their request for review November 15, 2023 03:59
@estarriolvetch
Copy link
Owner

The changes looks good to me. I will merge it into v0.8

@estarriolvetch estarriolvetch merged commit 7307f33 into estarriolvetch:v0.8 Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants