Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for the consumer #345

Open
lastmjs opened this issue Jul 5, 2017 · 7 comments
Open

Build for the consumer #345

lastmjs opened this issue Jul 5, 2017 · 7 comments

Comments

@lastmjs
Copy link

lastmjs commented Jul 5, 2017

I'm running into issues with this repo because the assets aren't built already for me. Now I'm going to have to manually go in and do an npm install and run the script to build. I might have to fork the repo so that I can change the package.json to do this for me, or just commit the built files. Why not build it for us? Or just add a post install script or something?

@michaelficarra
Copy link
Member

@lastmjs Are you talking about the browser build? I'd accept a PR to include the browser build in the npm package. But I'm strongly against keeping built files in the git repo.

@lastmjs
Copy link
Author

lastmjs commented Jul 6, 2017

Great, I might take you up on that then.

@gabejohnson
Copy link

gabejohnson commented Jan 3, 2018

It looks like tools/release.js is pretty out of date. @michaelficarra what's the current release process like?

@michaelficarra
Copy link
Member

@gabejohnson I'll make a release soon.

@tomgallagher
Copy link

I'd love to have a browser build easily available. I'm trying to work out how to build it from the npm package but I'm a beginner with node. Makes it hard to get at.

@nicolasnoble
Copy link

I'm interested in this as well. I'm a bit confused about the state of the releases anyway. It seems that the release tags starting at 1.7.0 no longer contain the built browser files, which seems to also affect the bower releases too.

I tried toying a bit with the tools/release.js script, but I couldn't figure out how this is supposed to work, or why the built files aren't present in github or in npm files. The .npmignore file seems to indicate we wouldn't publish the file escodegen.browser.js, but the file escodegen.browser.min.js should be present at a minimum.

Were the latest npm releases done without the release script by any chance ?

nicolasnoble added a commit to nicolasnoble/escodegen that referenced this issue Apr 16, 2018
@nicolasnoble
Copy link

I think I figured it out. See #368 as a proposed change for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants