Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Create content type offers to "override" default type #482

Closed
DennisL68 opened this issue Dec 12, 2022 · 4 comments
Closed

Issue: Create content type offers to "override" default type #482

DennisL68 opened this issue Dec 12, 2022 · 4 comments

Comments

@DennisL68
Copy link

DennisL68 commented Dec 12, 2022

Describe the bug
When I choose Create content type option on a markdown file with properties I'd like to use for a new content type, I get the option to Do you want to override the default content type?

This implies that the default Content Type definition will be preserved and just overridden in this case and more options will follow.

I don't want a random file with a misspelled property being the culprit of messing with the default content type.

To Reproduce
Probably by design...

Expected behavior

  • Change the question to Do you want to replace the default content type?

Screenshots
image

Desktop (please complete the following information):

  • Version: 1.74.0 (user setup)
  • Commit: 5235c6bb189b60b01b1f49062f4ffa42384f8c91
  • Date: 2022-12-05T16:38:16.075Z
  • Electron: 19.1.8
  • Chromium: 102.0.5005.167
  • Node.js: 16.14.2
  • V8: 10.2.154.15-electron.0
  • OS: Windows_NT x64 10.0.19044
  • Sandboxed: No
  • FrontMatter: 8.2.0
@DennisL68 DennisL68 added the bug Something isn't working label Dec 12, 2022
@DennisL68 DennisL68 changed the title Issue: Create content type offers to "ovverride" default type Issue: Create content type offers to "override" default type Dec 12, 2022
@estruyf
Copy link
Owner

estruyf commented Dec 14, 2022

As it is an override of the fields used in the default content type, maybe it is better to use: Do you want to override the default content type with the fields used in the current field?. What do you think?

@dennisl68-castra
Copy link

The configuration in the frontmatter.json for default is changed.

So I would say the default content type is over written and not over ridden.

@estruyf
Copy link
Owner

estruyf commented Dec 14, 2022

Good point!

Do you want to overwrite the default content type configuration with the fields used in the current field?

@dennisl68-castra
Copy link

That would clarify the point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants