Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(update): refactore code + added protection to events #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mardev-xyz
Copy link

No description provided.

xPlayer.showNotification(TranslateCap('invalid_quantity'))
end

if item.count <= 0 and count >= playerItemCount then
Copy link

@Kenshiin13 Kenshiin13 Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you refactor to use guard clauses, negate the condition properly.

  • >=<
  • andor
  • <=>

else
xPlayer.showNotification(TranslateCap('invalid_quantity'))
end
if count < 0 and item.count <= count then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you refactor to use guard clauses, negate the condition properly.

  • ><=
  • andor
  • >=<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In-Development
Development

Successfully merging this pull request may close these issues.

2 participants