feat(esx_mechanicjob): rework and rewrite by Tizas #25
Conversation
client/main.lua
Outdated
| cb(vehicle) | ||
| end) | ||
|
|
||
| Citizen.CreateThread(function() |
There was a problem hiding this comment.
Remove Citizen. you can just trigger CreateThread no need for Citizen in front of it.
client/main.lua
Outdated
| local playerPed = ESX.PlayerData.ped | ||
| local playerCoords = GetEntityCoords(playerPed) | ||
| local vehicle = ESX.Game.GetClosestVehicle(playerCoords) | ||
| if vehicle == -1 then cb(false) end |
There was a problem hiding this comment.
if not vehicle or vehicle == -1 then
return cb(false) -- return otherwise it will trigger cb(vehicle) as well
end
cb(vehicle)
There was a problem hiding this comment.
@Arctos2win ESX.Game.GetClosestVehicle will either return -1 or an entity handle. No need to check for nil
There was a problem hiding this comment.
@Arctos2win
ESX.Game.GetClosestVehiclewill either return -1 or an entity handle. No need to check for nil
didnt know the point was just the return before cb(false) otherwise cb(true) will also run even if there is no vehicle
client/modules/cloakroom.lua
Outdated
| ) | ||
| end | ||
|
|
||
| Citizen.CreateThread(function() |
There was a problem hiding this comment.
Citizen. can be removed
| end | ||
|
|
||
| local function EndJob() | ||
| if activeJob then |
There was a problem hiding this comment.
if not activeJob then
return ESX.ShowNotification(TranslateCap('no_active_job'))
end
| end, | ||
| inside = function() | ||
| DrawText3D(job.vehicleCoords, "~INPUT_PICKUP~ Start the job", 0.4) | ||
| if IsControlJustReleased(0, 38) then |
There was a problem hiding this comment.
You can use an outside local variabel for this
and then trigger this:
ESX.RegisterInteraction("mechanicjob", function()
MonitorRepair()
SetEntityDrawOutline(vehicle, false)
repairPoint:delete()
print("Delete Point")
end, function()
return isInside
end)
check how it works in here:
https://github.com/esx-framework/esx_core/blob/0426e760859f0d73213b499801165e6ad392ca38/%5Bcore%5D/es_extended/client/modules/interactions.lua#L9
| end | ||
|
|
||
| if not xPlayer.canCarryItem(itemName, count) then | ||
| xPlayer.showNotification('You cannot carry this amount of items.') |
There was a problem hiding this comment.
return xPlayer.showNotification
| ESX.RegisterUsableItem('tirekit', function(source) | ||
| local source = source | ||
| local xPlayer = ESX.GetPlayerFromId(source) | ||
| ESX.TriggerClientCallback(source , "esx_mechanicjob:client:checkForVehicle", function(closeVehicle) |
There was a problem hiding this comment.
same thing as the repairkit
| end, | ||
| inside = function() | ||
| DrawText3D(job.vehicleCoords, "~INPUT_PICKUP~ Start the job", 0.4) | ||
| if IsControlJustReleased(0, 38) then |
There was a problem hiding this comment.
do this with interactionkey
client/modules/npcJob.lua
Outdated
| end | ||
|
|
||
| local function MonitorRepair() | ||
| Citizen.CreateThread(function() |
| return EndJob() | ||
| end | ||
| print("Player Entered Zone") | ||
| SpawnVehicle(job.vehicleCoords, job.carModel) |
There was a problem hiding this comment.
Spawn server side vehicle and add an extra step on server to check timing
No description provided.