Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated pandas operations #502

Closed
lculibrk opened this issue Mar 2, 2020 · 3 comments
Closed

Deprecated pandas operations #502

lculibrk opened this issue Mar 2, 2020 · 3 comments
Labels

Comments

@lculibrk
Copy link

lculibrk commented Mar 2, 2020

Hi,

It looks like export theta is no longer functional with pandas >= 1.0, as I get this error when trying to run cnvkit.py export theta:

KeyError: 'Passing list-likes to .loc or [] with any missing labels is no longer supported, see https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#deprecate-loc-reindex-listlike'

downgrading pandas to 0.25.3 seems to be a workaround, although it seems that the conda recipe will automatically install the most recent pandas that it can find.

@etal etal added the bug label Apr 15, 2020
@etal
Copy link
Owner

etal commented Apr 15, 2020

Thanks, looks like the pandas 1.0 release happened while I was out on leave and broke this feature.

However, there are better methods for tumor purity estimation available now -- I recommend PureCN, which can take CNVkit's .cnn and .cnr files directly as input.

@tohsumi-repare
Copy link

Greetings. I was wondering if the theta export function could be updated so it works with the latest Panda? I am interested in running THetA using the output of CNVkit. Thank you very much!

@etal
Copy link
Owner

etal commented Aug 15, 2020

I've updated the pandas .loc calls for export theta here: f7bb71a

I see there are some other .loc[:, ...] calls elsewhere in the codebase that should probably be replaced, too.

@etal etal closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants