Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rna-import requires old pandas version #523

Closed
adamp83 opened this issue Jun 7, 2020 · 3 comments
Closed

rna-import requires old pandas version #523

adamp83 opened this issue Jun 7, 2020 · 3 comments
Labels

Comments

@adamp83
Copy link

adamp83 commented Jun 7, 2020

cnvkit.py raises an issue

AttributeError: 'Series' object has no attribute 'clip_upper'

when running rna-import. This occurs on a fresh install on MacOS, and also affects the docker container. It seems to be related to pandas, which removed the clip_upper method in their 1.0 release in Jan 2020 (https://pandas.pydata.org/docs/whatsnew/v1.0.0.html#removal-of-prior-version-deprecations-changes). Reverting to pandas 0.25 fixes it. Specifying the dependency version or updating the clip_upper method to clip(upper=threshold) here:

weights = [np.sqrt((gene_counts / gene_counts.quantile(.75)).clip_upper(1))]
(as described here: https://pandas.pydata.org/pandas-docs/version/0.24.2/reference/api/pandas.Series.clip_upper.html) should sort this.

Hope this helps.

@etal etal added the bug label Jun 7, 2020
@etal
Copy link
Owner

etal commented Jun 7, 2020

Thanks, looks like an easy fix.

@etal
Copy link
Owner

etal commented Aug 15, 2020

Fixed on git just now: 0860c97

@etal etal closed this as completed Aug 15, 2020
@harbourlab
Copy link

I still have this issue. Works with down-grading Pandas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants