do_scatter now returns a figure #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see your CI checks failed, but looking at the log, the issues don't appear to have anything to do with scatter.py, and that's the only file I touched. |
|
Yes, this looks good to me, and I think the unit test failures are a different issue (#397). Thanks for this contribution! |
|
Thanks for developing cnvkit, it's a very impressive piece of work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the scatter command sometimes returns a compound figure, I've set it up so that do_scatter returns a figure object rather than an axis object.
I've only partially tested this. I don't have any snv data to try it with so I wasn't able to test the situation where the plot contains both snv and cnv data.