Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional heatmap refactor #632

Closed
wants to merge 13 commits into from
Closed

Conversation

tskir
Copy link
Collaborator

@tskir tskir commented Jun 23, 2021

Based on work by @tetedange13 in #625. Additional changes:

  • Reverted to the original colormap specified by plots.cvg2rgb
  • Added back support for the do_desaturate parameter
  • Various additional refactoring and cleaning up

Closes #35.

@tskir tskir added the plots label Jun 23, 2021
@tskir tskir requested a review from etal June 23, 2021 21:25
@tskir
Copy link
Collaborator Author

tskir commented Jun 23, 2021

Some test plots, to make sure things still work:

heatmap (defaults)

image

heatmap --vertical

image

heatmap --by-bin

image

heatmap --desaturate

image

heatmap -c chr6

image

@tskir
Copy link
Collaborator Author

tskir commented Jun 23, 2021

Thank you once again @tetedange13 for initiating this work! I'm pretty sure that without this impetus coming from you, the heatmap issue wouldn't have been done for many more years :)

@tetedange13
Copy link
Contributor

tetedange13 commented Jun 24, 2021

Hi @tskir ,

Very nice idea to create a different ColorMap according to desaturate flag
=> More algorithmically efficient to map original log_values against a limited scale, rather than transforming each of them beforehand

Kind regards.
Felix.

@tskir
Copy link
Collaborator Author

tskir commented Jul 14, 2021

All changes from this PR are already incorporated in #625, closing

@tskir tskir closed this Jul 14, 2021
@tskir tskir removed the ready for merge Reviewed and approved at least once label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heatmap: Option to transpose the plot
2 participants