-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagram: switches for limiting by chromosome and for disabling gene labels #634
Conversation
Thanks Felix, everything looks good to me! |
Commit e8470dd should implement a feature discussed here Kind regards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code LGTM and I approve of the new feature. Without it, the way to get the same effect is by filtering the .cns and/or .cnr, as noted in the comments, to remove chromosomes or replace the gene names with -
.
The metavar for -c might be better as "LABEL" or "NAME" ( however it appears in other commands) rather than "RANGE" to reduce the temptation to type a basepair-level range.
Hi @etal, Thanks for your code review ! -c CHROMOSOME, --chromosome CHROMOSOME
Chromosome to display, e.g. 'chr1' (no chromosomal range allowed) Looking good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM now
Enhancement on
diagram
regarding #629Default:
With
--no-gene-labels
on:Closes #628. Closes #629.