Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refuse to start when opening a db created by nofreelistsnyc with freelistsyn option #5

Closed
xiang90 opened this issue Jun 22, 2017 · 2 comments
Closed

refuse to start when opening a db created by nofreelistsnyc with freelistsyn option #5

xiang90 opened this issue Jun 22, 2017 · 2 comments

Comments

@xiang90
Copy link
Contributor

xiang90 commented Jun 22, 2017

DB created with no freelist sync option wont persist freelist down to disk. Opening it with freelist option will fool the db to load in bad freelist, and might cause corruption.
@heyitsanthony
Copy link
Contributor

It should probably try to recover instead of only bailing. The freelist page could be set to 0 with NoFreeListSync so that if FreeListSync is enabled, it can see the freelist page is bogus and rebuild.

@xiang90
Copy link
Contributor Author

xiang90 commented Jun 22, 2017

ah, right. that is another option.

@heyitsanthony heyitsanthony mentioned this issue Jul 25, 2017
Merged
heyitsanthony added a commit that referenced this issue Jul 25, 2017
@heyitsanthony
rebuild freelist when opening with FreelistSync after NoFreelistSync
05bfb3b 
Writes pgidNoFreelist to the meta freelist page to detect when freelists
haven't been synced down.

Fixes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiang90 @heyitsanthony