Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx: load freelist on Check() [continuation of PR#49] #52

Merged
merged 2 commits into from
Sep 22, 2017

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Sep 21, 2017

Subbing in for @heyitsanthony.

This is #49, which fixes issue #45, with a couple minor pieces of feedback applied.

Anthony Romano added 2 commits September 18, 2017 16:23
Otherwise, nil dereference on ReadOnly DB

Fixes etcd-io#45
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ebf39dc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #52   +/-   ##
=========================================
  Coverage          ?   85.56%           
=========================================
  Files             ?        9           
  Lines             ?     1857           
  Branches          ?        0           
=========================================
  Hits              ?     1589           
  Misses            ?      159           
  Partials          ?      109
Impacted Files Coverage Δ
tx.go 76.21% <100%> (ø)
db.go 82.83% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf39dc...bdfe415. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Sep 22, 2017

lgtm

@xiang90 xiang90 merged commit 700b8ea into etcd-io:master Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants