Improve CreateBucketIfNotExists to avoid double searching the same key
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Please refer to #504 (comment) to get more details. |
|
nice refactor. /lgtm (non-binding) |
|
@ptabor could you take a look? This should be a safe improvement. |
Benchmark with this change: BenchmarkBucket_CreateBucketIfNotExists-10 123 9573035 ns/op 17930 B/op 37 allocs/op Benchmark with old implementnation: BenchmarkBucket_CreateBucketIfNotExists-10 121 10474415 ns/op 18147 B/op 46 allocs/op Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
cc @fuweid to take a look as well. |
|
thx all for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #118
Benchmark with this change:
Benchmark with old implementnation: