Fix bbolt keys and bbolt get to prevent them from panicking when no parameter provided

[Elbehery]

resolves #681

cc @ahrtr

[Elbehery]

@ahrtr i will go through all the cmds now

just this is to get early review

[Elbehery]

only get & keys cmds having this issue .. fixed both 👍🏽

[ahrtr]

Just as we talked in the meeting, the fix overall looks good. The only concern is on the output, which mixes the error message and the command usage. We should only need to take care of the error message, and let the command generic utility to take care of the usage.

Output of this PR

$ ./bbolt get
expected arguments are 'database path', 'bucket', and 'key': not enough arguments

$ ./bbolt keys
required arguments are 'database', and 'bucket': not enough arguments

Good example of other commands

$ ./bbolt surgery clear-page 
Error: db file path not provided
Usage:
  bbolt surgery clear-page <bbolt-file> [options] [flags]

Flags:
  -h, --help            help for clear-page
      --output string   path to the filePath db file
      --pageId uint     page Id

[Elbehery]

@ahrtr fixed, now the output

• keys cmd

 ./bbolt keys
usage: bolt keys PATH [BUCKET...]

Print a list of keys in the given (sub)bucket.
=======

Additional options include:

        --format
                Output format. One of: auto|ascii-encoded|hex|bytes|redacted (default=auto)

Print a list of keys in the given bucket.

Error: not enough arguments.

• get cmd

 ./bbolt get          
usage: bolt get PATH [BUCKET..] KEY

Print the value of the given key in the given (sub)bucket.

Additional options include:

        --format
                Output format. One of: auto|ascii-encoded|hex|bytes|redacted (default=auto)
        --parse-format
                Input format (of key). One of: ascii-encoded|hex (default=ascii-encoded)"

Error: not enough arguments.

[ahrtr]

Suggested change

	err := fmt.Errorf("Error: %w.\n", ErrNotEnoughArgs)
	fmt.Fprintln(cmd.Stderr, cmd.Usage())
	return err
	return ErrNotEnoughArgs

[Elbehery]

updated, but this way the usage will not be printed

[ahrtr]

Your previous implement (see below) isn't consistent with the cobra style command's output.

Overall it isn't a big deal for now. Let's refactor it in future.

$ ./bbolt keys
usage: bolt keys PATH [BUCKET...]

Print a list of keys in the given (sub)bucket.
=======

Additional options include:

	--format
		Output format. One of: auto|ascii-encoded|hex|bytes|redacted (default=auto)

Print a list of keys in the given bucket.

Error: not enough arguments.

[ahrtr]

Suggested change

	err := fmt.Errorf("Error: %w.\n", ErrNotEnoughArgs)
	fmt.Fprintln(cmd.Stderr, cmd.Usage())
	return err
	return ErrNotEnoughArgs

[Elbehery]

ditto

[ahrtr]

There are some inconsistency between the legacy commands and cobra style commands, we will need to do some refactor in future after we cut release-1.4 branch.

[Elbehery]

sure, i will do the cobra migration as we discussed after the release 👍🏽

[ahrtr]

lgtm

Thanks