Merge pull request #14146 from SimFG/parse_config

config: Add the default case when failing to parse the log rotate config json
etcd-io · Jun 23, 2022 · 33ba538 · 33ba538
2 parents 1da0b01 + 1dcd75f
commit 33ba538
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/server/embed/config_logging.go b/server/embed/config_logging.go
@@ -272,6 +272,8 @@ func setupLogRotation(logOutputs []string, logRotateConfigJSON string) error {
 			return fmt.Errorf("improperly formatted log rotation config: %v", err)
 		case errors.As(err, &unmarshalTypeError):
 			return fmt.Errorf("invalid log rotation config: %v", err)
+		default:
+			return fmt.Errorf("fail to unmarshal log rotation config: %v", err)
 		}
 	}
 	zap.RegisterSink("rotate", func(u *url.URL) (zap.Sink, error) {