Skip to content

Commit

Permalink
Merge pull request #8552 from heyitsanthony/fix-proxy-keys-only
Browse files Browse the repository at this point in the history
grpcproxy: respect KeysOnly flag
  • Loading branch information
heyitsanthony committed Sep 13, 2017
2 parents 1b85dad + 7f44644 commit 4afb99f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 15 deletions.
22 changes: 8 additions & 14 deletions e2e/ctl_v3_kv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,21 +222,15 @@ func getRevTest(cx ctlCtx) {
}

func getKeysOnlyTest(cx ctlCtx) {
var (
kvs = []kv{{"key1", "val1"}}
)
for i := range kvs {
if err := ctlV3Put(cx, kvs[i].key, kvs[i].val, ""); err != nil {
cx.t.Fatalf("getKeysOnlyTest #%d: ctlV3Put error (%v)", i, err)
}
if err := ctlV3Put(cx, "key", "val", ""); err != nil {
cx.t.Fatal(err)
}

cmdArgs := append(cx.PrefixArgs(), "get")
cmdArgs = append(cmdArgs, []string{"--prefix", "--keys-only", "key"}...)

err := spawnWithExpects(cmdArgs, []string{"key1", ""}...)
if err != nil {
cx.t.Fatalf("getKeysOnlyTest : error (%v)", err)
cmdArgs := append(cx.PrefixArgs(), []string{"get", "--keys-only", "key"}...)
if err := spawnWithExpect(cmdArgs, "key"); err != nil {
cx.t.Fatal(err)
}
if err := spawnWithExpects(cmdArgs, "val"); err == nil {
cx.t.Fatalf("got value but passed --keys-only")
}
}

Expand Down
4 changes: 3 additions & 1 deletion proxy/grpcproxy/kv.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,9 @@ func RangeRequestToOp(r *pb.RangeRequest) clientv3.Op {
if r.CountOnly {
opts = append(opts, clientv3.WithCountOnly())
}

if r.KeysOnly {
opts = append(opts, clientv3.WithKeysOnly())
}
if r.Serializable {
opts = append(opts, clientv3.WithSerializable())
}
Expand Down

0 comments on commit 4afb99f

Please sign in to comment.