Merge pull request #9557 from gyuho/lease-metrics

etcdserver: fix "lease_expired_total" metrics
etcd-io · Apr 10, 2018 · 943962d · 943962d
2 parents cf0a138 + 744c73e
commit 943962d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/etcdserver/server.go b/etcdserver/server.go
@@ -821,10 +821,13 @@ func (s *EtcdServer) run() {
 					lid := lease.ID
 					s.goAttach(func() {
 						ctx := s.authStore.WithRoot(s.ctx)
-						if _, lerr := s.LeaseRevoke(ctx, &pb.LeaseRevokeRequest{ID: int64(lid)}); lerr != nil {
+						_, lerr := s.LeaseRevoke(ctx, &pb.LeaseRevokeRequest{ID: int64(lid)})
+						if lerr == nil {
+							leaseExpired.Inc()
+						} else {
 							plog.Warningf("failed to revoke %016x (%q)", lid, lerr.Error())
 						}
-						leaseExpired.Inc()
+
 						<-c
 					})
 				}