Skip to content

Commit

Permalink
Merge pull request #18373 from redwrasse/redwrasse/wait-time-leq
Browse files Browse the repository at this point in the history
Fix wait time docs, tests to indicate trigger deadline geq to wait deadline.
  • Loading branch information
ahrtr authored Jul 30, 2024
2 parents c02dfcd + 7a82606 commit f181ced
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions pkg/wait/wait_time.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ import "sync"
type WaitTime interface {
// Wait returns a chan that waits on the given logical deadline.
// The chan will be triggered when Trigger is called with a
// deadline that is later than the one it is waiting for.
// deadline that is later than or equal to the one it is waiting for.
Wait(deadline uint64) <-chan struct{}
// Trigger triggers all the waiting chans with an earlier logical deadline.
// Trigger triggers all the waiting chans with an equal or earlier logical deadline.
Trigger(deadline uint64)
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/wait/wait_time_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ func TestWaitTime(t *testing.T) {
func TestWaitTestStress(t *testing.T) {
chs := make([]<-chan struct{}, 0)
wt := NewTimeList()
for i := 0; i < 10000; i++ {
for i := 0; i <= 10000; i++ {
chs = append(chs, wt.Wait(uint64(i)))
}
wt.Trigger(10000 + 1)
wt.Trigger(10000)

for _, ch := range chs {
select {
Expand All @@ -78,9 +78,9 @@ func BenchmarkWaitTime(b *testing.B) {
func BenchmarkTriggerAnd10KWaitTime(b *testing.B) {
for i := 0; i < b.N; i++ {
wt := NewTimeList()
for j := 0; j < 10000; j++ {
for j := 0; j <= 10000; j++ {
wt.Wait(uint64(j))
}
wt.Trigger(10000 + 1)
wt.Trigger(10000)
}
}

0 comments on commit f181ced

Please sign in to comment.