-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientv3: snapshot status does not check database integrity #10108
Comments
I’m strongly in favor of adding the bbolt check to snapshot status. |
@jingyih would it be possible to share this snapshot for the sake of experimentation? Is the underlying data in any way sensitive? |
@hexfusion we can’t share the one we’ve got on hand, but I can try to produce one that can be shared publicly. |
@jpbetz, thanks I would appreciate that. |
@xiang90 @hexfusion The corrupted snapshot file is due to freelist corruption. It was fixed and backported all the way to v3.1. The corrupted snapshot file was found on one of our GKE cluster where it is using v3.0. |
Version
etcd Version: 3.3.0+git
Git SHA: f32bc50
Go Version: go1.10.3
Go OS/Arch: linux/amd64
Issue
We have a corrupted snapshot file, identifiable by running
bbolt check
tool. When users doetcdctl snapshot status
, it should notify user if the snapshot file is corrupted.I will send out a PR to add database integrity verification in snapshot status.
Example output
The text was updated successfully, but these errors were encountered: