clientv3: add test for snapshot status #10148
Conversation
|
lgtm |
| sp := NewV3(zap.NewExample()) | ||
| _, err := sp.Status(dbPath) | ||
| expectedErrString := | ||
| "snapshot file integrity check failed. 2 errors found.\n" + |
There was a problem hiding this comment.
this is a little bit too strict. i would rather just to make sure the error message include some key words... or if sp.Status's return message changes just a little bit, this unit test breaks.
There was a problem hiding this comment.
I agree. At least I should remove the 2nd and 3rd lines, which are the error messages from bbolt. Any changes to those error messages in bbolt would break this. Thanks for pointing out.
|
@gyuho |
|
@gyuho |
jingyih
force-pushed
the
add_unit_test_for_snapshot_file_integrity
branch
from
e2b27a5
to
647f6f1
Compare
|
lgtm goword failure is odd, is it really including comma as a token in the string is spell checking? Or am I misunderstanding? |
|
Triggering rebuild to pick up goword fix in other PR. |
|
Yeah, for now we can whitelist here https://github.com/etcd-io/etcd/blob/master/.words. |
jingyih
force-pushed
the
add_unit_test_for_snapshot_file_integrity
branch
from
647f6f1
to
bdb00b9
Compare
Add unit test to check if we can correctly identify a corrupted snapshot backup file.
jingyih
force-pushed
the
add_unit_test_for_snapshot_file_integrity
branch
from
bdb00b9
to
87beb83
Compare
Add unit test to check if we can correctly identify a corrupted snapshot backup file.
This is a follow up to #10109, where backup file integrity check was added to snapshot status.
Also adding an example snapshot backup file, where its underlying database freelist is corrupted. We saw this issue in our production cluster, this file is an example test file that is reproduced to have the same type of issue.
/cc @gyuho @xiang90 @hexfusion @jpbetz