Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a way to configure grpc.MaxCallRecvMsgSize #12576

Closed
spacewander opened this issue Dec 22, 2020 · 6 comments · Fixed by #13077
Closed

Is there a way to configure grpc.MaxCallRecvMsgSize #12576

spacewander opened this issue Dec 22, 2020 · 6 comments · Fixed by #13077

Comments

@spacewander
Copy link
Contributor

After #9043, the grpc client can set MaxCallRecvMsgSize when creating a request.

But when the client accesses etcd via http (through the proxy of grpc-gateway), it seems there is not a way to configure grpc.MaxCallRecvMsgSize?
@spacewander spacewander mentioned this issue Dec 22, 2020
Closed
@agargi
Copy link
Contributor

agargi commented Dec 28, 2020

@spacewander Should this not be a gRPC Gateway question? I believe gRPC Gateway may be providing this kind of capability through metadata sent as part of request header.

@spacewander
Copy link
Contributor Author

@agargi
MaxCallRecvMsgSize is a client option, not a metadata name. AFAIK, gRPC Gateway doesn't provide a feature to set it via HTTP request.

@stale
Copy link

stale bot commented Mar 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 29, 2021
@spacewander
Copy link
Contributor Author

Does the problem still exist?

@stale stale bot removed the stale label Mar 29, 2021
@simonhou
Copy link

@spacewander Our apisix use etcd v3.4, still exist.

@spacewander spacewander mentioned this issue May 14, 2021
Closed
spacewander added a commit to spacewander/etcd that referenced this issue Jun 3, 2021
@spacewander
server: unlimit the recv msg size of grpc-gateway
947a8d9 
Fix etcd-io#12576
spacewander added a commit to spacewander/etcd that referenced this issue Jun 3, 2021
@spacewander
embed: unlimit the recv msg size of grpc-gateway
576861e 
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
@spacewander spacewander mentioned this issue Jun 3, 2021
Merged
@spacewander
Copy link
Contributor Author

@simonhou
I have just submitted a PR to solve the issue

tangcong pushed a commit to tangcong/etcd that referenced this issue Jun 10, 2021
@spacewander
embed: unlimit the recv msg size of grpc-gateway
4044223 
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
tangcong pushed a commit to tangcong/etcd that referenced this issue Jun 10, 2021
@spacewander
embed: unlimit the recv msg size of grpc-gateway
53e04b2 
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
tangcong pushed a commit to tangcong/etcd that referenced this issue Jun 11, 2021
@spacewander
embed: unlimit the recv msg size of grpc-gateway
628fa18 
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
wilsonwang371 pushed a commit to wilsonwang371/etcd that referenced this issue Oct 29, 2021
@spacewander @wilsonwang371
embed: unlimit the recv msg size of grpc-gateway
2484540 
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
wilsonwang371 pushed a commit to wilsonwang371/etcd that referenced this issue Nov 3, 2021
@spacewander @wilsonwang371
embed: unlimit the recv msg size of grpc-gateway
0945f5b 
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
tjungblu pushed a commit to tjungblu/etcd that referenced this issue Sep 8, 2022
@spacewander @tjungblu
embed: unlimit the recv msg size of grpc-gateway
8132878 
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.

Fix etcd-io#12576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

embed: unlimit the recv msg size of grpc-gateway spacewander/etcd
3 participants
@simonhou @spacewander @agargi