-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate /v2/keys/_etcd/machines #1279
Comments
I think 1) is reasonable, then we leave the door open for storing other unexposed things in future (e.g. |
I am trying to understand why we need to provide an empty key space at first. In my opinion, it is good to provide the configuration information in a reserved key path. It does not have to be hidden.
No matter how we change the "path" (as solution 1) or where we put the data (as solution 2), we still need to think about what configuration data we want to expose to user (external vs internal) and what operations we want to support on that (we probably do not want the random user update/remove a member configuration). |
Yes, please. |
@xiangli-cmu i think i should update the title to |
@xiangli-cmu it's not just about an empty key space. As you mentioned, we likely do not want to allow users to do arbitrary operations ( |
@unihorn i do not think so.
I do not think we MUST provide a "clean" root space. Does any storage/database system ever aim to do that? If the user cares, they can always create a sub dir themselves. @jonboulle Yea. The real problem is permission control. I do not know... Personally I still think it is fine to have a special reversed key special for all etcd public information/configuration. |
@xiangli-cmu I think our divergence sits on which is the root space. In my view, '/v2/' is the root space, and '/v2/keys/' is the space for users to play with keys. '/v2/members', '/v2/stats' are stuffs mounted for system usage. |
+1 to what @unihorn said. |
This is fixed by #1335 |
Reasons for the change:
Possible target location:
/v2/members/
Implementation options:
I prefer 1.
still digging it... Open for ideas
The text was updated successfully, but these errors were encountered: