Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track stabilization of --experimental-watch-progress-notify-interval flag #13779

Open
serathius opened this issue Mar 10, 2022 · 3 comments
Open

Track stabilization of --experimental-watch-progress-notify-interval flag #13779

serathius opened this issue Mar 10, 2022 · 3 comments
Assignees
@chaochn47
Labels
help wanted stage/tracked
Milestone
etcd-v3.6

Comments

@serathius
Copy link
Member

serathius commented Mar 10, 2022 •
edited

This is tracking issue that tracks graduation of this feature. Let's work towards stabilization of the feature by discussing what steps should be taken for graduation.
Context #13775
@serathius serathius added this to the etcd-v3.6 milestone Mar 10, 2022
@serathius serathius changed the title Stabilize --experimental-watch-progress-notify-interval flag Track stabilization of --experimental-watch-progress-notify-interval flag Mar 14, 2022
@chaochn47
Copy link
Member

chaochn47 commented May 10, 2022 •
edited

Adding some reference from kubernetes. Looks like GCE defaults to 5s. I could imagine graduation of the flag will be breaking change for etcd users so etcd-v3.6 release should call it out.

# ETCD_PROGRESS_NOTIFY_INTERVAL defines the interval for etcd watch progress notify events.
export ETCD_PROGRESS_NOTIFY_INTERVAL="${ETCD_PROGRESS_NOTIFY_INTERVAL:-5s}"

ref. https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/config-default.sh#L524-L525

  if [[ -n "${ETCD_PROGRESS_NOTIFY_INTERVAL:-}" ]]; then
    etcd_extra_args+=" --experimental-watch-progress-notify-interval=${ETCD_PROGRESS_NOTIFY_INTERVAL}"
  fi

ref. https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L1850-L1852

Please assign to me and I will take a look at this feature. Thanks!

@aojea
Copy link

aojea commented Jul 26, 2022

This is now a default in kubeadm created clusters too

kubernetes/kubernetes#111383

@pacoxu pacoxu mentioned this issue Dec 23, 2022
Open
2 tasks
@kkkkun
Copy link
Contributor

kkkkun commented Jun 25, 2023

Adding some reference from kubernetes. Looks like GCE defaults to 5s. I could imagine graduation of the flag will be breaking change for etcd users so etcd-v3.6 release should call it out.

# ETCD_PROGRESS_NOTIFY_INTERVAL defines the interval for etcd watch progress notify events.
export ETCD_PROGRESS_NOTIFY_INTERVAL="${ETCD_PROGRESS_NOTIFY_INTERVAL:-5s}"

ref. https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/config-default.sh#L524-L525

  if [[ -n "${ETCD_PROGRESS_NOTIFY_INTERVAL:-}" ]]; then
    etcd_extra_args+=" --experimental-watch-progress-notify-interval=${ETCD_PROGRESS_NOTIFY_INTERVAL}"
  fi

ref. https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L1850-L1852

Please assign to me and I will take a look at this feature. Thanks!

The flag experimental-watch-progress-notify-interval is relied on feature WatchList in kube-apiserver. So we should track to stable in v3.6 ?

p0lyn0mial added a commit to p0lyn0mial/kubernetes that referenced this issue Jan 19, 2024
@p0lyn0mial
test/integration: enable experimental-watch-progress-notify-interval …
b3c01da 
…flag for etcd

The experimental-watch-progress-notify-interval flag specifies an interval at which etcd sends data to the kube-api server.

It is used by the WatchBookmark feature ( kube-apiserver) which is GA since 1.17.
It will also be used by a new WatchList and WatchListClient features which are targeted to Beta in this release (1.30)
All GCE tests set the flag as well.

Given the above, a default installation must pass the flag required by the kube-apiserver to etcd. Otherwise, some features will not work.

etcd-io/etcd#13779 tracks stabilization of the flag in etcd.
@p0lyn0mial p0lyn0mial mentioned this issue Jan 19, 2024
Closed
p0lyn0mial added a commit to p0lyn0mial/kubernetes that referenced this issue Jan 19, 2024
@p0lyn0mial
test/integration: enable experimental-watch-progress-notify-interval …
189dcce 
…flag for etcd

The experimental-watch-progress-notify-interval flag specifies an interval at which etcd sends data to the kube-api server.

It is used by the WatchBookmark feature ( kube-apiserver) which is GA since 1.17.
It will also be used by a new WatchList and WatchListClient features which are targeted to Beta in this release (1.30)
All GCE tests set the flag as well.

Given the above, a default installation must pass the flag required by the kube-apiserver to etcd. Otherwise, some features will not work.

etcd-io/etcd#13779 tracks stabilization of the flag in etcd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaochn47 chaochn47

Labels
help wanted stage/tracked
Milestone
etcd-v3.6
Development

No branches or pull requests
4 participants
@serathius @aojea @kkkkun @chaochn47