Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] [3.5] CI is not configured to run Go vulnerability check #17549

Closed
4 tasks done
ivanvc opened this issue Mar 7, 2024 · 3 comments
Closed
4 tasks done

[3.4] [3.5] CI is not configured to run Go vulnerability check #17549

ivanvc opened this issue Mar 7, 2024 · 3 comments
Assignees
Labels
area/security area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/bug

Comments

@ivanvc
Copy link
Member

ivanvc commented Mar 7, 2024

Bug report criteria

What happened?

Early this week, multiple CVEs were disclosed, and there was a Go version update, along with a release of google.golang.org/protobuf. The main branch has the Go vulnerability check configured. But release-3.4 and release-3.5 don't. While the main branch had CI failures (i.e. https://github.com/etcd-io/etcd/actions/runs/8190871384/job/22398801424). The others didn't.

What did you expect to happen?

Both branches should have failed CI runs.

How can we reproduce it (as minimally and precisely as possible)?

Review release-3.4 and release-3.5 branches' .github/workflows, to reveal that there's no such check.

Anything else we need to know?

No response

Etcd version (please run commands below)

$ etcd --version
# paste output here

$ etcdctl version
# paste output here

Etcd configuration (command line flags or environment variables)

paste your configuration here

Etcd debug information (please run commands below, feel free to obfuscate the IP address or FQDN in the output)

$ etcdctl member list -w table
# paste output here

$ etcdctl --endpoints=<member list> endpoint status -w table
# paste output here

Relevant log output

No response

@ivanvc ivanvc added the type/bug label Mar 7, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Mar 7, 2024

Follow up from #17543 (comment).

@ivanvc
Copy link
Member Author

ivanvc commented Mar 7, 2024

/assign

@ivanvc
Copy link
Member Author

ivanvc commented Mar 8, 2024

/close

😂 I think prow bot doesn't run on issues. This issue can be closed now ;)

@jmhbnz jmhbnz closed this as completed Mar 9, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/bug
Development

No branches or pull requests

2 participants