-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Add govuln GitHub workflow #17550
[3.5] Add govuln GitHub workflow #17550
Conversation
Hi @ivanvc. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - New workflow is now correctly picking up the recent CVE affecting release-3.5
.
This is a good signal to have for the stable release branches, thanks @ivanvc.
Would it make sense to also enable it as a nightly job for these branches? |
Thanks for the fix. Please rebase this PR.
Adding a workflow being triggered on each PR might be good enough for now. If we all agree to do it, then let's add a nightly for main, 3.5 and 3.4. |
Signed-off-by: Ivan Valdes <ivan@vald.es>
49c7b2f
to
67afad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks
Enables
govuln
in the release-3.5 branch.Part of #17549.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.