Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Prow plugins for etcd PRs #18110

Open
ArkaSaha30 opened this issue Jun 3, 2024 · 8 comments
Open

Enable Prow plugins for etcd PRs #18110

ArkaSaha30 opened this issue Jun 3, 2024 · 8 comments
Assignees
@ArkaSaha30
Labels
area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature

Comments

@ArkaSaha30
Copy link
Contributor

ArkaSaha30 commented Jun 3, 2024 •
edited

What would you like to be added?

Plugin enablement for etcd in test-infra.
Suggested plugins to be added:

Why is this needed?

There are useful Prow plugins that etcd can leverage to minimize manual efforts. One of them is the cherrypicker plugin, which can backport any PR to a specific branch with just a /cherry-pick <branch_name> comment on the PR.
Example: containerd/containerd#10257 (comment)
@ArkaSaha30
Copy link
Contributor Author

cc @ahrtr @jmhbnz

@ahrtr
Copy link
Member

ahrtr commented Jun 3, 2024

Sounds good to me. /cherry-pick might work for 3.5, but not for 3.4, which has huge difference with main.

@jmhbnz jmhbnz added area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 3, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Jun 3, 2024

Thanks for proposing this @ArkaSaha30. Enabling the cherry pick plugin makes sense to me, please feel free to raise a pr if you have capacity 🙏🏻

@ArkaSaha30
Copy link
Contributor Author

/assign

ArkaSaha30 pushed a commit to ArkaSaha30/test-infra that referenced this issue Jun 4, 2024
Enable cherrypicker plugin for etcd-io/etcd
d99c589 
This commit will add cherrypicker external plugin
for etcd-io/etcd repo.
Issue ref: etcd-io/etcd#18110

Signed-off-by: arkas1 <arkas1@vmware.com>
ArkaSaha30 pushed a commit to ArkaSaha30/test-infra that referenced this issue Jun 4, 2024
Enable cherrypicker plugin for etcd-io/etcd
b061a7a 
This commit will add cherrypicker external plugin
for etcd-io/etcd repo.
Issue ref: etcd-io/etcd#18110

Signed-off-by: arkas1 <arkas1@vmware.com>
ArkaSaha30 added a commit to ArkaSaha30/test-infra that referenced this issue Jun 4, 2024
@ArkaSaha30
Enable cherrypicker plugin for etcd-io/etcd
9a4e1e5 
This commit will add cherrypicker external plugin
for etcd-io/etcd repo.
Issue ref: etcd-io/etcd#18110

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ArkaSaha30 ArkaSaha30 mentioned this issue Jun 4, 2024
Merged
@jmhbnz
Copy link
Member

jmhbnz commented Jun 6, 2024

Hi @ArkaSaha30 - We raised this at sig-etcd triage meeting, are there any other plugins you suggest we enable or can we close this now?

@ivanvc
Copy link
Member

ivanvc commented Jun 6, 2024

Based on kubernetes/k8s.io#6102 (comment), do we also want to enable tide, lgtm, and approve?

@ArkaSaha30
Copy link
Contributor Author

Based on kubernetes/k8s.io#6102 (comment), do we also want to enable tide, lgtm, and approve?

Yes! Along with these we can also add 'size' which will label the PRs based on how lengthy it is. WDYT @jmhbnz ?

@jmhbnz
Copy link
Member

jmhbnz commented Jun 7, 2024

Based on kubernetes/k8s.io#6102 (comment), do we also want to enable tide, lgtm, and approve?

I am not confident we are ready as a project for tide / auto merging of pull requests. It would be helpful to update this issue with a description of what the proposed plugin does and what impact this would have for the etcd project.

I am happy to enable the pr sizing plugin as that is very low risk.

This was referenced Jun 10, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArkaSaha30 ArkaSaha30

Labels
area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ivanvc @ahrtr @jmhbnz @ArkaSaha30