Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdctl: port to use github.com/coreos/etcd/client #2411

Closed
philips opened this issue Mar 2, 2015 · 7 comments
Closed

etcdctl: port to use github.com/coreos/etcd/client #2411

philips opened this issue Mar 2, 2015 · 7 comments

Comments

@philips
Copy link
Contributor

philips commented Mar 2, 2015

We need to port etcdctl to client to make sure the API makes sense and that the implementation works.

@philips philips added this to the v2.1.0 milestone Mar 2, 2015
@xiang90 xiang90 modified the milestones: v2.2.0, v2.1.0 Mar 13, 2015
@chancez
Copy link
Contributor

chancez commented Apr 15, 2015

I wouldn't mind taking a stab at this, but go-etcd has a ton of logic explicitly just for dealing with curl examples and debugging info. Do we want to port that stuff over in this process as well?

It would be trivial to port things over to the new commands (except a few that are missing), but there's some client level stuff that wont be as quick.

@xiang90
Copy link
Contributor

xiang90 commented Apr 15, 2015

@ecnahc515 I do not think so. Just port enough for the command to work well. I played with it a little. And I really want to get rid of the func pointers all over the place.

@chancez
Copy link
Contributor

chancez commented Apr 15, 2015

Alright, I can easily do the trivial parts. I would really like to make sure this new client API works well enough for use in other projects, as I've started using it. So getting it into etcdctl will be a great start for showing us what it needs.

@xiang90
Copy link
Contributor

xiang90 commented Apr 15, 2015

@ecnahc515 Yes. That is the intention.

But the etcdctl also needs a cleanup. So I would suggest you to rewrite the command one by one rather than trying to modify the helper funcs.

@chancez
Copy link
Contributor

chancez commented Apr 15, 2015

Ok. I'll do that. I can see where it might be a problem to try and use all the helpers.

@yichengq
Copy link
Contributor

progress at #2913

@xiang90
Copy link
Contributor

xiang90 commented Jun 30, 2015

closed by #3083

@xiang90 xiang90 closed this as completed Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants