-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl: port to use github.com/coreos/etcd/client #2411
Comments
I wouldn't mind taking a stab at this, but go-etcd has a ton of logic explicitly just for dealing with curl examples and debugging info. Do we want to port that stuff over in this process as well? It would be trivial to port things over to the new commands (except a few that are missing), but there's some client level stuff that wont be as quick. |
@ecnahc515 I do not think so. Just port enough for the command to work well. I played with it a little. And I really want to get rid of the func pointers all over the place. |
Alright, I can easily do the trivial parts. I would really like to make sure this new client API works well enough for use in other projects, as I've started using it. So getting it into etcdctl will be a great start for showing us what it needs. |
@ecnahc515 Yes. That is the intention. But the etcdctl also needs a cleanup. So I would suggest you to rewrite the command one by one rather than trying to modify the helper funcs. |
Ok. I'll do that. I can see where it might be a problem to try and use all the helpers. |
progress at #2913 |
closed by #3083 |
We need to port etcdctl to client to make sure the API makes sense and that the implementation works.
The text was updated successfully, but these errors were encountered: