etcdctl: make commands use etcd/client #2913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
changed the title
xiang90
force-pushed
the
ctl-get
branch
2 times, most recently
from
4cf1525
to
be344d9
Compare
|
|
||
| if resp.Node.Dir { | ||
| fmt.Fprintln(os.Stderr, fmt.Sprintf("%s: is a directory", resp.Node.Key)) | ||
| os.Exit(1) |
There was a problem hiding this comment.
the intention is to port to use new client. i do not want to clean up this kind of thing for the old codebase right now (since there are quite a lot).
|
FYI if you end up working on the watcher part of this, you might have issues canceling the watcher with |
|
@ecnahc515 Thanks. I will take a look. |
xiang90
changed the title
xiang90
force-pushed
the
ctl-get
branch
2 times, most recently
from
ebd600e
to
910d110
Compare
This was referenced Jun 24, 2015
Closed
|
Closing. Will merge into 2.2 dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.