-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile breaks #8548
Comments
This only affects v1.6.x of grpc or master branch. It works for v1.5.x branch. |
OK, grpc broke their API again. Thanks for the heads up. |
@gyuo I get the following compile error with latest etcd and grpc.
Using v1.5.x branch I get the same error, so it's now broken for v1.5.x and v1.6.x of grpc and etcd master branch. |
For the moment I can compile with branch "release-3.2" for etcd and branch "v1.5.x" for grpc. |
@Mickep76 For master branch, etcd requires Go 1.9. |
@Mickep76 Ping? |
For me it works with the etcd master branch and grpc 1.6.0
|
@Mickep76 Please reopen if you still have issues. |
With go1.9 it builds out of the box. Might be wise to put a notice in the README.md. Thx |
Guys, I am using grpc 1.6.0 and go 1.9 and etcd 3.2.9 fails to build. What do you suggest doing? Are you guys going to release grpc 1.6.0 compatible version in near future? I do not want to pull master etcd due to possibility of unstable changes. Thanks |
@singhmal etcd v3.2.x still uses grpc-go v1.2.1 and Go 1.8.4. https://github.com/coreos/etcd/blob/release-3.2/glide.yaml |
@gyuho Thanks for quick turnaround but I can not change my infrastructure to use older grpc-go or go. What do you suggest I should be doing? |
Please wait until 3.3 release. There are still a lot of things to stabilize before releasing 3.3. |
Ahh I see, any ETA for 3.3 ? I will make do with master for the time being. Thanks a lot. |
Please note that master branch is not stable. |
I am fully aware of master being unstable but I got no choice. I take the responsibility of the unstability. |
I try etcd v3.2.9 today with golang 1.9 and still getting the error
|
Using glide to hold etcd package to be at branch
|
I'm getting the same error as above. Any update on a release date for v3.3? |
@drewlandis We still have many pending issues. And also planning another gRPC dependency upgrade. |
Bug reporting
There seems to be a dep. issue in the clientv3, when compiling I get the following error:
Code:
The text was updated successfully, but these errors were encountered: