Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream warning logging in v3 rpc pkg #9085

Closed
xiang90 opened this issue Jan 3, 2018 · 5 comments
Closed

stream warning logging in v3 rpc pkg #9085

xiang90 opened this issue Jan 3, 2018 · 5 comments
Assignees
@spzala

Comments

@xiang90
Copy link
Contributor

xiang90 commented Jan 3, 2018

We probably should not log expected errors (for example if the watcher is closed by the client, we should not log a warning saying that the context is canceled.)

/cc @gyuho @jpbetz @hexfusion @spzala
@xiang90
Copy link
Contributor Author

xiang90 commented Jan 3, 2018

an example of bad logging

2017-12-28 04:54:32.106592 W | etcdserver/api/v3rpc: failed to receive watch request from gRPC stream ("rpc error: code = Canceled desc = context canceled")

@gyuho
Copy link
Contributor

gyuho commented Jan 3, 2018 •
edited
Loading

Those are now debug level #9080 but we could make it warning after filtering out those context errors.

@xiang90
Copy link
Contributor Author

xiang90 commented Jan 3, 2018 •
edited
Loading

I think we should make non expected errors at warning level, and expected ones (like user cancellation) at debug level.

@gyuho
Copy link
Contributor

gyuho commented Jan 3, 2018

@spzala Do you want to work on this? It will be pretty straightforward. Please refer to https://github.com/coreos/etcd/blob/c699470d3b27d2e968df313110255734105687fa/clientv3/client.go#L532-L554 on error parsing.

@spzala
Copy link
Member

spzala commented Jan 3, 2018 •
edited
Loading

@gyuho sure, I was actually thinking the same :-). Thanks much for the above info, that will help!

spzala added a commit to spzala/etcd that referenced this issue Jan 5, 2018
@spzala
Log: debug user cancellation and log warning for rest
4293f21 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes etcd-io#9085
@spzala spzala mentioned this issue Jan 5, 2018
Merged
spzala added a commit to spzala/etcd that referenced this issue Jan 6, 2018
@spzala
Log: debug user cancellation and log warning for rest
96c1c19 
The context errors with Canceled or DeadlineExceeded code are typically for user
cancellation which should be at debug level. For other error codes we should
display a warning.

Fixes etcd-io#9085
spzala added a commit to spzala/etcd that referenced this issue Jan 6, 2018
@spzala
Log: debug user cancellation and log warning for rest
ea0a8ff 
The context errors with Canceled or DeadlineExceeded code are typically for user
cancellation which should be at debug level. For other error codes we should
display a warning.

Fixes etcd-io#9085
spzala added a commit to spzala/etcd that referenced this issue Jan 6, 2018
@spzala
Log: debug user cancellation and log warning for rest
102716f 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes etcd-io#9085
spzala added a commit to spzala/etcd that referenced this issue Jan 6, 2018
@spzala
Log: debug user cancellation and log warning for rest
42388cf 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes etcd-io#9085
spzala added a commit to spzala/etcd that referenced this issue Jan 7, 2018
@spzala
Log: debug user cancellation and log warning for rest
4b50c66 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes etcd-io#9085
spzala added a commit to spzala/etcd that referenced this issue Jan 8, 2018
@spzala
Log: debug user cancellation and log warning for rest
481832e 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes etcd-io#9085
spzala added a commit to spzala/etcd that referenced this issue Jan 8, 2018
@spzala
Log: debug user cancellation and log warning for rest
c2185e1 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes etcd-io#9085
spzala added a commit to spzala/etcd that referenced this issue Jan 8, 2018
@spzala
etcdserver/api/v3rpc: debug user cancellation and log warning for rest
a66d7c3 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes etcd-io#9085
gyuho pushed a commit that referenced this issue Jan 8, 2018
@spzala @gyuho
etcdserver/api/v3rpc: debug user cancellation and log warning for rest
ec43197 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes #9085
gyuho pushed a commit that referenced this issue Jan 8, 2018
@spzala @gyuho
etcdserver/api/v3rpc: debug user cancellation and log warning for rest
8449dc8 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes #9085
gyuho pushed a commit that referenced this issue Jan 9, 2018
@spzala @gyuho
etcdserver/api/v3rpc: debug user cancellation and log warning for rest
df4036a 
The context error with cancel code is typically for user cancellation which
should be at debug level. For other error codes we should display a warning.

Fixes #9085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spzala spzala

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xiang90 @spzala @gyuho