-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update grpc-go to v1.20.0 #10624
Conversation
cc @jpbetz |
cc @hexfusion |
Whenever we upgrade gRPC, a lot of things break... I will investigate more in May. |
This version includes patch from grpc/grpc-go#2695 which fixes etcd-io#9956 Signed-off-by: André Martins <aanm90@gmail.com>
Since we are bumping up the grpc version, can we try to bump the version to 1.22? We need to pick up grpc/grpc-go#2777 which is included in 1.21 and above to fix #10087. |
@jingyih I will be working on gRPC balancer fix, with gRPC 1.22 bump up. Will start working on it after July 4 |
@gyuho I can dedicate cycles to assist in this effort as well, please touch base so we can coordinate. |
@hexfusion Let's sync up later next week. The changes that I need in clientv3 needs latest gRPC. So, I will bundle them in my later PR. |
Closing, to use gRPC 1.22.0 |
@gyuho would be great to have a linked issue or PR to keep track of the follow-up. |
@pires Yes, I will keep posting updates here as well! |
This version includes patch from
grpc/grpc-go#2695 which
fixes #9956
Signed-off-by: André Martins aanm90@gmail.com