Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation metadata for 3.3 branch #10692

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Documentation metadata for 3.3 branch #10692

merged 2 commits into from
Apr 30, 2019

Conversation

lucperkins
Copy link
Contributor

Contributing guidelines

Please read our contribution workflow before submitting a pull request.

Signed-off-by: lucperkins <lucperkins@gmail.com>
@lucperkins lucperkins changed the base branch from master to release-3.3 April 29, 2019 17:32
@lucperkins lucperkins changed the title Documentation metadata for 3.3 branch [WIP] Documentation metadata for 3.3 branch Apr 29, 2019
Signed-off-by: lucperkins <lucperkins@gmail.com>
@lucperkins lucperkins changed the title [WIP] Documentation metadata for 3.3 branch Documentation metadata for 3.3 branch Apr 30, 2019
@philips
Copy link
Contributor

philips commented Apr 30, 2019

I trust this is fine. LGTM.

@lucperkins lucperkins merged commit c46aa44 into etcd-io:release-3.3 Apr 30, 2019
hexfusion pushed a commit to openshift/etcd that referenced this pull request Sep 26, 2019
* Update Documentation folder

Signed-off-by: lucperkins <lucperkins@gmail.com>

* Re-add README file

Signed-off-by: lucperkins <lucperkins@gmail.com>
hexfusion pushed a commit to openshift/etcd that referenced this pull request Mar 20, 2020
* Update Documentation folder

Signed-off-by: lucperkins <lucperkins@gmail.com>

* Re-add README file

Signed-off-by: lucperkins <lucperkins@gmail.com>
hexfusion pushed a commit to openshift/etcd that referenced this pull request Mar 21, 2020
* Update Documentation folder

Signed-off-by: lucperkins <lucperkins@gmail.com>

* Re-add README file

Signed-off-by: lucperkins <lucperkins@gmail.com>
@mitake
Copy link
Contributor

mitake commented Nov 29, 2020

I found that this PR introduces many updates which aren't available in 3.3. e.g. auth related flags which release-3.3 doesn't have were backported as reported in #12471 Also, release notes related to 3.4 (https://github.com/etcd-io/etcd/pull/10692/files#diff-17da1e89a79a8340240e419595e65a7ed7a55ed34402edbccde75151a0ebb3f9R87) and 3.5 (https://github.com/etcd-io/etcd/pull/10692/files#diff-17da1e89a79a8340240e419595e65a7ed7a55ed34402edbccde75151a0ebb3f9R73) were backported to 3.3.
@lucperkins Could you share the purpose of this PR? I think we should fix the problems or revert this from release-3.3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants