-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add workaround for go-resty import to go.mod and fix import paths #10773
Conversation
I added two commits that show the result of updatedep.sh, and another commit that shows that things "work" when we just delete the self-vendored copies from vendor. I don't intend to merge this, we need to figure out why the self-vendoring happens. I tried but no dice yet. |
Doesn't come back via
Also wasn't able to find anything that imported this by grepping through the sourcecode. |
Codecov Report
@@ Coverage Diff @@
## master #10773 +/- ##
==========================================
+ Coverage 62.51% 62.67% +0.15%
==========================================
Files 392 392
Lines 37157 37157
==========================================
+ Hits 23230 23289 +59
+ Misses 12330 12296 -34
+ Partials 1597 1572 -25
Continue to review full report at Codecov.
|
I think I have seen similar issue after running the updatedep script. Could not figure out why. Thanks for digging into this. |
PTAL, I think I got it (second commit) |
When I tried this, we still have "v3" in all the import paths. So it might be a different issue. |
Can we try again removing v3 at the top of the line https://github.com/etcd-io/etcd/blob/master/go.mod? I forgot to delete that part. Sorry for delay. |
Please try #10781. |
go-resty is imported under its old import path by grpc-gateway. This works around that problem until we pick up a version of grpc-gateway that has the imports fixed. See: go-resty/resty#230
Yep, works! Closing this PR since it's no longer needed. Thanks @gyuho. |
@tbg Thanks! |
go-resty is imported under its old import path by grpc-gateway.
This works around that problem until we pick up a version of
grpc-gateway that has the imports fixed.
See: go-resty/resty#230
Also fix the import paths so that updatedep.sh works again.