*: add inflight snapshot metrics #11009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbetz
reviewed
Aug 8, 2019
etcdserver/metrics.go
Outdated
| applySnapshotInflights = prometheus.NewGauge(prometheus.GaugeOpts{ | ||
| Namespace: "etcd", | ||
| Subsystem: "server", | ||
| Name: "snapshot_apply_inflights_total", |
There was a problem hiding this comment.
nit: Since this is not a network metric (and subsystem=server), maybe instead of "inflight" name it something like "snapshot_apply_in_progress_total" ?
etcdserver/api/rafthttp/http.go
Outdated
| @@ -287,6 +289,7 @@ func (h *snapshotHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| plog.Error(msg) | |||
| } | |||
| http.Error(w, msg, http.StatusInternalServerError) | |||
| snapshotReceiveInflights.WithLabelValues(from).Dec() | |||
There was a problem hiding this comment.
nit: Would be great if we could somehow structure the code blocks we only need to make one call to Dec(), ideally in a defer. The code looks correct, but I worry we'll end up miscounting at some point...
|
@jpbetz All addressed. Thanks! |
jpbetz
reviewed
Aug 8, 2019
| @@ -90,6 +90,7 @@ func (s *snapshotSender) send(merged snap.Message) { | |||
| plog.Infof("start to send database snapshot [index: %d, to %s]...", m.Snapshot.Metadata.Index, types.ID(m.To)) | |||
| } | |||
|
|
|||
| snapshotSendInflights.WithLabelValues(to).Inc() | |||
|
LGTM after other defer Thanks! |
…cd_network_snapshot_receive_inflights_total" Useful for deciding when to terminate the unhealthy follower. If the follower is receiving a leader snapshot, operator may wait. Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
|
Agree with Joe. Thanks! |
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
|
LGTM! |
|
LGTM thanks @gyuho! |
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Aug 8, 2019
*: add inflight snapshot metrics
|
Could we backport this to 3.2 and 3.3? |
|
@wenjiaswe Sure! |
This was referenced Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no way to find out if current follower is receiving a leader snapshot. If snapshot receive is inflight, the operator may wait until it's done, rather than marking the follower as unhealthy. This is useful for a large cluster, where snapshot sends takes several minutes (e.g. 4 GB).
/cc @xiang90 @jpbetz @jingyih