Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc/kvstore: Optimize compaction, slove conflict for #11150 #11330

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

shenjiangc
Copy link
Contributor

mvcc/kvstore: Optimize compaction

when the number of key-value index is greater than one million, compact take too long and blocks other requests.
Move the “kvindex.Compact” to “fifoSched.Schedule” func

slove conflict for #11150

@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #11330 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #11330     +/-   ##
=========================================
+ Coverage   64.05%   64.26%   +0.2%     
=========================================
  Files         403      403             
  Lines       37970    37969      -1     
=========================================
+ Hits        24323    24400     +77     
+ Misses      12011    11940     -71     
+ Partials     1636     1629      -7
Impacted Files Coverage Δ
mvcc/kvstore.go 86.05% <100%> (-0.05%) ⬇️
auth/simple_token.go 68.29% <0%> (-18.7%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
clientv3/leasing/cache.go 88.88% <0%> (-2.78%) ⬇️
clientv3/concurrency/election.go 79.68% <0%> (-2.35%) ⬇️
proxy/grpcproxy/watch.go 88.75% <0%> (-1.19%) ⬇️
clientv3/leasing/kv.go 89.7% <0%> (-1%) ⬇️
etcdserver/server.go 68.67% <0%> (+0.19%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd011c...72cc5dc. Read the comment docs.

@jingyih
Copy link
Contributor

jingyih commented Nov 4, 2019

Code change looks good to me. Could you please clean up the commits?

@WIZARD-CXY
Copy link
Contributor

LGTM

…ompact take too long and blocks other requests
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingyih
Copy link
Contributor

jingyih commented Nov 5, 2019

Test failure unrelated.

@jingyih jingyih merged commit cbc1340 into etcd-io:master Nov 5, 2019
gyuho added a commit that referenced this pull request Mar 31, 2020
…0-upstream-release-3.4

Cherry pick of #11330 on release-3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants