Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: build etcd-test image for multiarch #11398

Closed
wants to merge 1 commit into from

Conversation

zhlhahaha
Copy link

@zhlhahaha zhlhahaha commented Nov 27, 2019

Script for building multi-arch etcd-test image

Signed-off-by: Howard Zhang howard.zhang@arm.com

For etcd to officially support a arm64 platform, CI test is necessary. However, the etcd-test image which is used by CI test is only support amd64. This PR is for building etcd-test image for multiarch platform.

Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #11398 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11398      +/-   ##
==========================================
- Coverage   64.58%   63.93%   -0.65%     
==========================================
  Files         403      403              
  Lines       37969    37969              
==========================================
- Hits        24522    24276     -246     
- Misses      11814    12045     +231     
- Partials     1633     1648      +15
Impacted Files Coverage Δ
auth/options.go 35% <0%> (-57.5%) ⬇️
pkg/transport/timeout_conn.go 60% <0%> (-20%) ⬇️
client/keys.go 73.86% <0%> (-17.59%) ⬇️
auth/store.go 45.33% <0%> (-17.25%) ⬇️
auth/range_perm_cache.go 45.56% <0%> (-15.19%) ⬇️
clientv3/balancer/utils.go 88.46% <0%> (-11.54%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
auth/simple_token.go 82.11% <0%> (-4.88%) ⬇️
clientv3/txn.go 95.55% <0%> (-4.45%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1139d3...99461d1. Read the comment docs.

Script for building multi-arch etcd-test image

Signed-off-by: Howard Zhang <howard.zhang@arm.com>
@zhlhahaha zhlhahaha changed the title build etcd-test image for multiarch *: build etcd-test image for multiarch Nov 28, 2019
@zhlhahaha
Copy link
Author

@xiang90
As we discussed in #11270, this patch is for build etcd-test image for multi-arch. Can you review it when you have time?

@lubinszARM
Copy link

lubinszARM commented Dec 10, 2019

Related issue: #10318
Related checklist: https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/supported-platform.md#supporting-a-new-system-platform

Hi @heyitsanthony @glevand @spzala @mkumatag @gyuho @xiang90 @jingyih
We want to remove ETCD_UNSUPPORTED_ARCH=arm64, and try to deliver the PR-s according to the checklist to support etcd on Arm64 platform.

So, can anyone help to review the PR?
Thanks.

cc @vielmetti

@zhlhahaha zhlhahaha requested a review from gyuho January 17, 2020 08:20
@lubinszARM
Copy link

Related PR: #7714

@lubinszARM
Copy link

/assign @heyitsanthony

@stale
Copy link

stale bot commented Jul 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 8, 2020
@stale stale bot closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants