Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update bbolt v1.3.4, zap v1.14.1 #11709

Merged
merged 1 commit into from
Mar 20, 2020
Merged

vendor: update bbolt v1.3.4, zap v1.14.1 #11709

merged 1 commit into from
Mar 20, 2020

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Mar 19, 2020

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@codecov-io
Copy link

Codecov Report

Merging #11709 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11709      +/-   ##
==========================================
+ Coverage   66.52%   66.60%   +0.07%     
==========================================
  Files         403      403              
  Lines       36731    36731              
==========================================
+ Hits        24435    24463      +28     
+ Misses      10806    10772      -34     
- Partials     1490     1496       +6     
Impacted Files Coverage Δ
auth/options.go 47.50% <0.00%> (-45.00%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0.00%> (-16.13%) ⬇️
auth/simple_token.go 79.83% <0.00%> (-9.25%) ⬇️
pkg/netutil/netutil.go 61.47% <0.00%> (-7.38%) ⬇️
pkg/tlsutil/tlsutil.go 86.20% <0.00%> (-6.90%) ⬇️
clientv3/leasing/cache.go 87.22% <0.00%> (-4.45%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0.00%> (-4.09%) ⬇️
etcdserver/util.go 95.23% <0.00%> (-3.58%) ⬇️
clientv3/leasing/util.go 95.00% <0.00%> (-3.34%) ⬇️
etcdserver/api/v3rpc/watch.go 82.45% <0.00%> (-2.46%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a45d3...3ffb3ae. Read the comment docs.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @gyuho - lgtm
Only thing I can think of is Changelog update and I guess eventually we will bump to go 1.14 for CI.

@gyuho gyuho merged commit 72526ce into etcd-io:master Mar 20, 2020
@gyuho
Copy link
Contributor Author

gyuho commented Mar 20, 2020

Will update CHANGELOG in the following PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants