Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #11652 #11670 #11699 #11710 #11748

Conversation

tangcong
Copy link
Contributor

@tangcong tangcong commented Apr 5, 2020

Cherry pick of #11652 #11670 #11699 #11710 on release-3.4.

#11652: *: fix auth revision corruption bug
#11670: auth: print warning log when error is ErrAuthOldRevision
#11699: *: refactor consistent index
#11710: auth: ensure RoleGrantPermission is compatible with older

@tangcong tangcong force-pushed the automated-cherry-pick-of-#11652-#11670-#11699-#11710-origin-release-3.4 branch from aa945eb to 9104789 Compare April 5, 2020 10:50
@tangcong
Copy link
Contributor Author

tangcong commented Apr 5, 2020

#11652 fix a data corruption bug when restarting etcd,but the old consistent index implementation is not elegant to call.
#11699 refactor consistent index to make the code look more concise and elegant.
#11670 add log when etcd server failed to apply command. Could you merge these changes into the 3.4 and 3.3 branches? Thanks. @jingyih @gyuho

@tangcong
Copy link
Contributor Author

tangcong commented Apr 5, 2020

ci failed to pass due to no space left on device.

@jingyih
Copy link
Contributor

jingyih commented Apr 5, 2020

I prefer we do not backport #11699. It was recently merged and we do not have enough soak time. Ideally we should ensure each patch release is strictly better. Backporting code refactor code adds more risk which overweights the gain in my opinion.

@gyuho
Copy link
Contributor

gyuho commented Apr 5, 2020

Agree with @jingyih. Refactored code doesn't need be backported.

@tangcong
Copy link
Contributor Author

tangcong commented Apr 5, 2020

thanks. i see. i will close this pr and submit another pr.

@tangcong tangcong closed this Apr 5, 2020
@tangcong tangcong deleted the automated-cherry-pick-of-#11652-#11670-#11699-#11710-origin-release-3.4 branch February 26, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants